eslint: indent
function hello (name) {
console.log('hi', name)
}
eslint: quotes
console.log('hello there')
$("<div class='box'>")
eslint: no-unused-vars
function myFunction () {
var result = something() // ✗ avoid
}
eslint: keyword-spacing
if (condition) { ... } // ✓ ok
if(condition) { ... } // ✗ avoid
eslint: space-before-function-paren
function name (arg) { ... } // ✓ ok
function name(arg) { ... } // ✗ avoid
run(function () { ... }) // ✓ ok
run(function() { ... }) // ✗ avoid
===
替代 ==
。obj == null
可以用来检查 null || undefined
。eslint: eqeqeq
if (name === 'John') // ✓ ok
if (name == 'John') // ✗ avoid
if (name !== 'John') // ✓ ok
if (name != 'John') // ✗ avoid
eslint: space-infix-ops
// ✓ ok
var x = 2
var message = 'hello, ' + name + '!'
// ✗ avoid
var x=2
var message = 'hello, '+name+'!'
eslint: comma-spacing
// ✓ ok
var list = [1, 2, 3, 4]
function greet (name, options) { ... }
// ✗ avoid
var list = [1,2,3,4]
function greet (name,options) { ... }
eslint: brace-style
// ✓ ok
if (condition) {
// ...
} else {
// ...
}
// ✗ avoid
if (condition)
{
// ...
}
else
{
// ...
}
eslint: curly
// ✓ ok
if (options.quiet !== true) console.log('done')
// ✓ ok
if (options.quiet !== true) {
console.log('done')
}
// ✗ avoid
if (options.quiet !== true)
console.log('done')
err
参数。eslint: handle-callback-err
// ✓ ok
run(function (err) {
if (err) throw err
window.alert('done')
})
// ✗ avoid
run(function (err) {
window.alert('done')
})
window.
前缀。document
, console
and navigator
.eslint: no-undef
window.alert('hi') // ✓ ok
eslint: no-multiple-empty-lines
// ✓ ok
var value = 'hello world'
console.log(value)
// ✗ avoid
var value = 'hello world'
console.log(value)
?
和 :
与他们所负责的代码处于同一行eslint: operator-linebreak
// ✓ ok
var location = env.development ? 'localhost' : 'www.api.com'
// ✓ ok
var location = env.development
? 'localhost'
: 'www.api.com'
// ✗ avoid
var location = env.development ?
'localhost' :
'www.api.com'
eslint: one-var
// ✓ ok
var silent = true
var verbose = true
// ✗ avoid
var silent = true, verbose = true
// ✗ avoid
var silent = true,
verbose = true
===
)错写成了等号(=
)。eslint: no-cond-assign
// ✓ ok
while ((m = text.match(expr))) {
// ...
}
// ✗ avoid
while (m = text.match(expr)) {
// ...
}
eslint: block-spacing
function foo () {return true} // ✗ avoid
function foo () { return true } // ✓ ok
eslint: camelcase
function my_function () { } // ✗ avoid
function myFunction () { } // ✓ ok
var my_var = 'hello' // ✗ avoid
var myVar = 'hello' // ✓ ok
eslint: comma-dangle
var obj = {
message: 'hello', // ✗ avoid
}
eslint: comma-style
var obj = {
foo: 'foo'
,bar: 'bar' // ✗ avoid
}
var obj = {
foo: 'foo',
bar: 'bar' // ✓ ok
}
eslint: dot-location
console.
log('hello') // ✗ avoid
console
.log('hello') // ✓ ok
eslint: eol-last
eslint: func-call-spacing
console.log ('hello') // ✗ avoid
console.log('hello') // ✓ ok
eslint: key-spacing
var obj = { 'key' : 'value' } // ✗ avoid
var obj = { 'key' :'value' } // ✗ avoid
var obj = { 'key':'value' } // ✗ avoid
var obj = { 'key': 'value' } // ✓ ok
eslint: new-cap
function animal () {}
var dog = new animal() // ✗ avoid
function Animal () {}
var dog = new Animal() // ✓ ok
eslint: new-parens
function Animal () {}
var dog = new Animal // ✗ avoid
var dog = new Animal() // ✓ ok
eslint: accessor-pairs
var person = {
set name (value) { // ✗ avoid
this._name = value
}
}
var person = {
set name (value) {
this._name = value
},
get name () { // ✓ ok
return this._name
}
}
super
eslint: constructor-super
class Dog {
constructor () {
super() // ✗ avoid
}
}
class Dog extends Mammal {
constructor () {
super() // ✓ ok
}
}
eslint: no-array-constructor
var nums = new Array(1, 2, 3) // ✗ avoid
var nums = [1, 2, 3] // ✓ ok
arguments.callee
和 arguments.caller
。eslint: no-caller
function foo (n) {
if (n <= 0) return
arguments.callee(n - 1) // ✗ avoid
}
function foo (n) {
if (n <= 0) return
foo(n - 1)
}
eslint: no-class-assign
class Dog {}
Dog = 'Fido' // ✗ avoid
const
声明的变量。eslint: no-const-assign
const score = 100
score = 125 // ✗ avoid
eslint: no-constant-condition
if (false) { // ✗ avoid
// ...
}
if (x === 0) { // ✓ ok
// ...
}
while (true) { // ✓ ok
// ...
}
eslint: no-control-regex
var pattern = /\x1f/ // ✗ avoid
var pattern = /\x20/ // ✓ ok
debugger
。eslint: no-debugger
function sum (a, b) {
debugger // ✗ avoid
return a + b
}
delete
操作。eslint: no-delete-var
var name
delete name // ✗ avoid
eslint: no-dupe-args
function sum (a, b, a) { // ✗ avoid
// ...
}
function sum (a, b, c) { // ✓ ok
// ...
}
eslint: no-dupe-class-members
class Dog {
bark () {}
bark () {} // ✗ avoid
}
eslint: no-dupe-keys
var user = {
name: 'Jane Doe',
name: 'John Doe' // ✗ avoid
}
switch
语句中不要定义重复的 case
分支。eslint: no-duplicate-case
switch (id) {
case 1:
// ...
case 1: // ✗ avoid
}
eslint: no-duplicate-imports
import { myFunc1 } from 'module'
import { myFunc2 } from 'module' // ✗ avoid
import { myFunc1, myFunc2 } from 'module' // ✓ ok
eslint: no-empty-character-class
const myRegex = /^abc[]/ // ✗ avoid
const myRegex = /^abc[a-z]/ // ✓ ok
eslint: no-empty-pattern
const { a: {} } = foo // ✗ avoid
const { a: { b } } = foo // ✓ ok
eval()
。eslint: no-eval
eval( "var result = user." + propName ) // ✗ avoid
var result = user[propName] // ✓ ok
catch
中不要对错误重新赋值。eslint: no-ex-assign
try {
// ...
} catch (e) {
e = 'new value' // ✗ avoid
}
try {
// ...
} catch (e) {
const newVal = 'new value' // ✓ ok
}
eslint: no-extend-native
Object.prototype.age = 21 // ✗ avoid
eslint: no-extra-bind
const name = function () {
getName()
}.bind(user) // ✗ avoid
const name = function () {
this.getName()
}.bind(user) // ✓ ok
eslint: no-extra-boolean-cast
const result = true
if (!!result) { // ✗ avoid
// ...
}
const result = true
if (result) { // ✓ ok
// ...
}
eslint: no-extra-parens
const myFunc = (function () { }) // ✗ avoid
const myFunc = function () { } // ✓ ok
switch
一定要使用 break
来将条件分支正常中断。eslint: no-fallthrough
switch (filter) {
case 1:
doSomething() // ✗ avoid
case 2:
doSomethingElse()
}
switch (filter) {
case 1:
doSomething()
break // ✓ ok
case 2:
doSomethingElse()
}
switch (filter) {
case 1:
doSomething()
// fallthrough // ✓ ok
case 2:
doSomethingElse()
}
eslint: no-floating-decimal
const discount = .5 // ✗ avoid
const discount = 0.5 // ✓ ok
eslint: no-func-assign
function myFunc () { }
myFunc = myOtherFunc // ✗ avoid
eslint: no-global-assign
window = {} // ✗ avoid
eval()
。eslint: no-implied-eval
setTimeout("alert('Hello world')") // ✗ avoid
setTimeout(function () { alert('Hello world') }) // ✓ ok
eslint: no-inner-declarations
if (authenticated) {
function setAuthUser () {} // ✗ avoid
}
RegExp
构造器传入非法的正则表达式。eslint: no-invalid-regexp
RegExp('[a-z') // ✗ avoid
RegExp('[a-z]') // ✓ ok
eslint: no-irregular-whitespace
function myFunc () /*<NBSP>*/{} // ✗ avoid
__iterator__
。eslint: no-iterator
Foo.prototype.__iterator__ = function () {} // ✗ avoid
eslint: no-label-var
var score = 100
function game () {
score: while (true) { // ✗ avoid
score -= 10
if (score > 0) continue score
break
}
}
eslint: no-labels
label:
while (true) {
break label // ✗ avoid
}
eslint: no-lone-blocks
function myFunc () {
{ // ✗ avoid
myOtherFunc()
}
}
function myFunc () {
myOtherFunc() // ✓ ok
}
eslint: no-mixed-spaces-and-tabs
eslint: no-multi-spaces
const id = 1234 // ✗ avoid
const id = 1234 // ✓ ok
eslint: no-multi-str
const message = 'Hello \
world' // ✗ avoid
new
创建对象实例后需要赋值给变量。eslint: no-new
new Character() // ✗ avoid
const character = new Character() // ✓ ok
Function
构造器。eslint: no-new-func
var sum = new Function('a', 'b', 'return a + b') // ✗ avoid
Object
构造器。eslint: no-new-object
let config = new Object() // ✗ avoid
new require
。eslint: no-new-require
const myModule = new require('my-module') // ✗ avoid
Symbol
构造器。eslint: no-new-symbol
const foo = new Symbol('foo') // ✗ avoid
eslint: no-new-wrappers
const message = new String('hello') // ✗ avoid
eslint: no-obj-calls
const math = Math() // ✗ avoid
eslint: no-octal
const num = 042 // ✗ avoid
const num = '042' // ✓ ok
eslint: no-octal-escape
const copyright = 'Copyright \251' // ✗ avoid
__dirname
和 __filename
时尽量避免使用字符串拼接。eslint: no-path-concat
const pathToFile = __dirname + '/app.js' // ✗ avoid
const pathToFile = path.join(__dirname, 'app.js') // ✓ ok
getPrototypeOf
来替代 __proto__
。eslint: no-proto
const foo = obj.__proto__ // ✗ avoid
const foo = Object.getPrototypeOf(obj) // ✓ ok
eslint: no-redeclare
let name = 'John'
let name = 'Jane' // ✗ avoid
let name = 'John'
name = 'Jane' // ✓ ok
eslint: no-regex-spaces
const regexp = /test value/ // ✗ avoid
const regexp = /test {3}value/ // ✓ ok
const regexp = /test value/ // ✓ ok
eslint: no-return-assign
function sum (a, b) {
return result = a + b // ✗ avoid
}
function sum (a, b) {
return (result = a + b) // ✓ ok
}
eslint: no-self-assign
name = name // ✗ avoid
esint: no-self-compare
if (score === score) {} // ✗ avoid
eslint: no-sequences
if (doSomething(), !!test) {} // ✗ avoid
eslint: no-shadow-restricted-names
let undefined = 'value' // ✗ avoid
eslint: no-sparse-arrays
let fruits = ['apple',, 'orange'] // ✗ avoid
eslint: no-tabs
eslint: no-template-curly-in-string
const message = 'Hello ${name}' // ✗ avoid
const message = `Hello ${name}` // ✓ ok
this
前请确保 super()
已调用。eslint: no-this-before-super
class Dog extends Animal {
constructor () {
this.legs = 4 // ✗ avoid
super()
}
}
throw
抛错时,抛出 Error
对象而不是字符串。eslint: no-throw-literal
throw 'error' // ✗ avoid
throw new Error('error') // ✓ ok
eslint: no-trailing-spaces
undefined
来初始化变量。eslint: no-undef-init
let name = undefined // ✗ avoid
let name
name = 'value' // ✓ ok
eslint: no-unmodified-loop-condition
for (let i = 0; i < items.length; j++) {...} // ✗ avoid
for (let i = 0; i < items.length; i++) {...} // ✓ ok
eslint: no-unneeded-ternary
let score = val ? val : 0 // ✗ avoid
let score = val || 0 // ✓ ok
return
,throw
,continue
和 break
后不要再跟代码。eslint: no-unreachable
function doSomething () {
return true
console.log('never called') // ✗ avoid
}
finally
代码块中不要再改变程序执行流程。eslint: no-unsafe-finally
try {
// ...
} catch (e) {
// ...
} finally {
return 42 // ✗ avoid
}
eslint: no-unsafe-negation
if (!key in obj) {} // ✗ avoid
.call()
和 .apply()
。eslint: no-useless-call
sum.call(null, 1, 2, 3) // ✗ avoid
eslint: no-useless-computed-key
const user = { ['name']: 'John Doe' } // ✗ avoid
const user = { name: 'John Doe' } // ✓ ok
eslint: no-useless-constructor
class Car {
constructor () { // ✗ avoid
}
}
eslint: no-useless-escape
let message = 'Hell\o' // ✗ avoid
eslint: no-useless-rename
import { config as config } from './config' // ✗ avoid
import { config } from './config' // ✓ ok
eslint: no-whitespace-before-property
user .name // ✗ avoid
user.name // ✓ ok
with
。eslint: no-with
with (val) {...} // ✗ avoid
eslint: object-property-newline
const user = {
name: 'Jane Doe', age: 30,
username: 'jdoe86' // ✗ avoid
}
const user = { name: 'Jane Doe', age: 30, username: 'jdoe86' } // ✓ ok
const user = {
name: 'Jane Doe',
age: 30,
username: 'jdoe86'
} // ✓ ok
eslint: padded-blocks
if (user) {
// ✗ avoid
const name = getName()
}
if (user) {
const name = getName() // ✓ ok
}
eslint: rest-spread-spacing
fn(... args) // ✗ avoid
fn(...args) // ✓ ok
eslint: semi-spacing
for (let i = 0 ;i < items.length ;i++) {...} // ✗ avoid
for (let i = 0; i < items.length; i++) {...} // ✓ ok
eslint: space-before-blocks
if (admin){...} // ✗ avoid
if (admin) {...} // ✓ ok
eslint: space-in-parens
getName( name ) // ✗ avoid
getName(name) // ✓ ok
eslint: space-unary-ops
typeof!admin // ✗ avoid
typeof !admin // ✓ ok
eslint: spaced-comment
//comment // ✗ avoid
// comment // ✓ ok
/*comment*/ // ✗ avoid
/* comment */ // ✓ ok
eslint: template-curly-spacing
const message = `Hello, ${ name }` // ✗ avoid
const message = `Hello, ${name}` // ✓ ok
NaN
的正确姿势是使用 isNaN()
。eslint: use-isnan
if (price === NaN) { } // ✗ avoid
if (isNaN(price)) { } // ✓ ok
typeof
进行比较操作。eslint: valid-typeof
typeof name === 'undefimed' // ✗ avoid
typeof name === 'undefined' // ✓ ok
eslint: wrap-iife
const getName = function () { }() // ✗ avoid
const getName = (function () { }()) // ✓ ok
const getName = (function () { })() // ✓ ok
yield *
中的 *
前后都要有空格。eslint: yield-star-spacing
yield* increment() // ✗ avoid
yield * increment() // ✓ ok
eslint: yoda
if (42 === age) { } // ✗ avoid
if (age === 42) { } // ✓ ok
eslint: semi
window.alert('hi') // ✓ ok
window.alert('hi'); // ✗ avoid
(
, [
, or `
等作为一行的开始。在没有分号的情况下代码压缩后会导致报错,而坚持这一规范则可避免出错。eslint: no-unexpected-multiline
// ✓ ok
;(function () {
window.alert('ok')
}())
// ✗ avoid
(function () {
window.alert('ok')
}())
// ✓ ok
;[1, 2, 3].forEach(bar)
// ✗ avoid
[1, 2, 3].forEach(bar)
// ✓ ok
;`hello`.indexOf('o')
// ✗ avoid
`hello`.indexOf('o')
备注:上面的写法只能说聪明过头了。
相比更加可读易懂的代码,那些看似投巧的写法是不可取的。
譬如:
;[1, 2, 3].forEach(bar)
建议的写法是:
var nums = [1, 2, 3]
nums.forEach(bar)
当前主流的代码压缩方案都是基于词法(AST-based)进行的,所以在处理无分号的代码时完全没有压力(何况 JavaScript 中分号本来就不是强制的)。
[自动化插入分号的做法]是安全可依赖的,而且其产出的代码能够在所有浏览器里很好地运行。 Closure compiler, yuicompressor, packer 还有 jsmin 都能正确地对这样的代码进行压缩处理。并没有任何性能相关的问题。
不得不说,Javascript 社区里的大牛们一直是错误的,并不能教给你最佳实践。真是让人忧伤啊。 我建议先弄清楚 JS 是怎样断句的(还有就是哪些地方看起来断了其实并没有),明白了这个后就可以随心写出漂亮的代码了。
一般来说,
\n
表示语句结束,除非:
- 该语句有未闭合的括号, 数组字面量, 对象字面量 或者其他不能正常结束一条语句的情况(譬如,以
.
或,
结尾)- 该语句是
--
或者++
(它会将后面的内容进行自增或减)- 该语句是
for()
,while()
,do
,if()
或者else
并且没有{
- 下一行以
[
,(
,+
,*
,/
,-
,,
,.
或者其他只会单独出现在两块内容间的二元操作符。第一条很容易理解。即使在 JSLint 中,也允许 JSON,构造器的括号中,以及使用
var
配合,
结尾来声明多个变量等这些情中包含\n
。第二条有点奇葩。 我还想不出谁会(除了这里用作讨论外)写出
i\n++\nj
这样的代码来,不过,顺便说一下,这种写法最后解析的结果是i; ++j
,而不是i++; j
。第三条也容易理解。
if (x)\ny()
等价于if (x) { y() }
。解释器会向下寻找到代码块或一条语句为止。
;
是条合法的 JavaScript 语句。所以if(x);
等价于if(x){}
,表示 “如果 x 为真,什么也不做。” 这种写法在循环里面可以看到,就是当条件判断与条件更新是同一个方法的时候。 不常见,但也不至于没听说过吧。第四条就是常见的 “看,说过要加分号!” 的情形。但这些情况可以通过在语句前面加上分号来解决,如果你确定该语句跟前面的没关系的话。举个例子,假如你想这样:
foo(); [1,2,3].forEach(bar);
那么完全可以这样来写:
foo() ;[1,2,3].forEach(bar)
后者的好处是分号比较瞩目,一旦习惯后便再也不会看到以
(
和[
开头又不带分号的语句了。